Commit bee026d0 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: max98088: Use WARN_ON() instead of BUG_ON() 



Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent ddb146da

sound/soc/codecs/max98088.c

+5 −3
Original line number Diff line number Diff line
@@ -621,8 +621,9 @@ static void m98088_eq_band(struct snd_soc_codec *codec, unsigned int dai, 
       unsigned int eq_reg;

       unsigned int i;



       BUG_ON(band > 4);

       BUG_ON(dai > 1);

	if (WARN_ON(band > 4) ||

	    WARN_ON(dai > 1))

		return;



       /* Load the base register address */

       eq_reg = dai ? M98088_REG_84_DAI2_EQ_BASE : M98088_REG_52_DAI1_EQ_BASE;
@@ -962,7 +963,8 @@ static int max98088_line_pga(struct snd_soc_dapm_widget *w, 
       struct max98088_priv *max98088 = snd_soc_codec_get_drvdata(codec);

       u8 *state;



       BUG_ON(!((channel == 1) || (channel == 2)));

	if (WARN_ON(!(channel == 1 || channel == 2)))

		return -EINVAL;



       switch (line) {

       case LINE_INA:

CRA Git | Maintained and supported by SUSTech CRA and CCSE