Commit beced88e authored Jun 05, 2018 by Rex Zhu Committed by Bjorn Helgaas Jun 29, 2018

PCI: Add check code for last image indicator not set



If the "last image" indicator was not set in the PCI data struct, print "No
more image in the PCI ROM" instead of looping back and printing "Invalid
PCI ROM header signature".

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

parent 445ec321

drivers/pci/rom.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -108,6 +108,12 @@ size_t pci_get_rom_size(struct pci_dev pdev, void __iomem rom, size_t size)
		/* Avoid iterating through memory outside the resource window */
		if (image >= rom + size)
		break;
		if (!last_image) {
		if (readw(image) != 0xAA55) {
		pci_info(pdev, "No more image in the PCI ROM\n");
		break;
		}
		}
		} while (length && !last_image);

		/* never return a size larger than the PCI resource window */

Admin message