Commit beb39db5 authored May 30, 2015 by Eric Dumazet Committed by David S. Miller May 31, 2015

udp: fix behavior of wrong checksums



We have two problems in UDP stack related to bogus checksums :

1) We return -EAGAIN to application even if receive queue is not empty.
   This breaks applications using edge trigger epoll()

2) Under UDP flood, we can loop forever without yielding to other
   processes, potentially hanging the host, especially on non SMP.

This patch is an attempt to make things better.

We might in the future add extra support for rt applications
wanting to better control time spent doing a recv() in a hostile
environment. For example we could validate checksums before queuing
packets in socket receive queue.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9eb0a5d1

net/ipv4/udp.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1345,10 +1345,8 @@ csum_copy_err:
		}
		unlock_sock_fast(sk, slow);

		if (noblock)
		return -EAGAIN;

		/* starting over for a new packet */
		/* starting over for a new packet, but check if we need to yield */
		cond_resched();
		msg->msg_flags &= ~MSG_TRUNC;
		goto try_again;
		}

net/ipv6/udp.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -525,10 +525,8 @@ csum_copy_err:
		}
		unlock_sock_fast(sk, slow);

		if (noblock)
		return -EAGAIN;

		/* starting over for a new packet */
		/* starting over for a new packet, but check if we need to yield */
		cond_resched();
		msg->msg_flags &= ~MSG_TRUNC;
		goto try_again;
		}

Admin message