Commit beaae8cd authored Jan 22, 2018 by Darrick J. Wong

xfs: always zero di_flags2 when we free the inode



Always zero the di_flags2 field when we free the inode so that we never
end up with an on-disk record for an unallocated inode that also has the
reflink iflag set.  This is in keeping with the general principle that
only files can have the reflink iflag set, even though we'll zero out
di_flags2 if we ever reallocate the inode.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 09ac8623

fs/xfs/xfs_inode.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2449,6 +2449,7 @@ xfs_ifree(

		VFS_I(ip)->i_mode = 0; /* mark incore inode as free */
		ip->i_d.di_flags = 0;
		ip->i_d.di_flags2 = 0;
		ip->i_d.di_dmevmask = 0;
		ip->i_d.di_forkoff = 0; /* mark the attr fork not in use */
		ip->i_d.di_format = XFS_DINODE_FMT_EXTENTS;

Admin message