staging: rtl8723bs: removed unwanted if..else condition (be88dae8) · Commits · 戴 / test

There is use of if..elseif..else condition which has same logic in all three blocks. Removed if..else block and placed log message instead that. Signed-off-by:

Aliasgar Surti <aliasgar.surti500@gmail.com> Reviewed-by:

Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/1571321906-15074-1-git-send-email-aliasgar.surti500@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8723bs/core/rtw_cmd.c

+3 −13

Original line number	Diff line number	Diff line
		@@ -507,19 +507,9 @@ post_process:

		cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
		if (cmd_process_time > 1000) {
		if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
		DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
		ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
		/* rtw_warn_on(1); */
		} else if (pcmd->cmdcode == GEN_CMD_CODE(_Set_MLME_EVT)) {
		DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
		ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
		/* rtw_warn_on(1); */
		} else {
		DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
		ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
		/* rtw_warn_on(1); */
		}
		ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
		cmd_process_time);
		}

		/* call callback function for post-processed */

Admin message