Commit be59167c authored by David Howells's avatar David Howells
Browse files

afs: Remove some unused bits 



Remove three bits:

 (1) afs_server::no_epoch is neither set nor used.

 (2) afs_server::have_result is set and a wakeup is applied to it, but
     nothing looks at it or waits on it.

 (3) afs_vl_dump_edestaddrreq() prints afs_addr_list::probed, but nothing
     sets it for VL servers.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent ae83d0b4

fs/afs/fs_probe.c

+1 −4
Original line number Original line Diff line number Diff line
@@ -117,12 +117,9 @@ out: 
	       (unsigned int)rtt, ret);

	       (unsigned int)rtt, ret);





	have_result |= afs_fs_probe_done(server);

	have_result |= afs_fs_probe_done(server);

	if (have_result) {

	if (have_result)

		server->probe.have_result = true;

		wake_up_var(&server->probe.have_result);

		wake_up_all(&server->probe_wq);

		wake_up_all(&server->probe_wq);

}

}

}





/*

/*

 * Probe all of a fileserver's addresses to find out the best route and to

 * Probe all of a fileserver's addresses to find out the best route and to

fs/afs/internal.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -533,12 +533,10 @@ struct afs_server { 
		u32		abort_code;

		u32		abort_code;

		u32		cm_epoch;

		u32		cm_epoch;

		short		error;

		short		error;

		bool		have_result;

		bool		responded:1;

		bool		responded:1;

		bool		is_yfs:1;

		bool		is_yfs:1;

		bool		not_yfs:1;

		bool		not_yfs:1;

		bool		local_failure:1;

		bool		local_failure:1;

		bool		no_epoch:1;

		bool		cm_probed:1;

		bool		cm_probed:1;

		bool		said_rebooted:1;

		bool		said_rebooted:1;

		bool		said_inconsistent:1;

		bool		said_inconsistent:1;

fs/afs/vl_rotate.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -302,8 +302,8 @@ static void afs_vl_dump_edestaddrreq(const struct afs_vl_cursor *vc) 
				pr_notice("VC:  - nr=%u/%u/%u pf=%u\n",

				pr_notice("VC:  - nr=%u/%u/%u pf=%u\n",

					  a->nr_ipv4, a->nr_addrs, a->max_addrs,

					  a->nr_ipv4, a->nr_addrs, a->max_addrs,

					  a->preferred);

					  a->preferred);

				pr_notice("VC:  - pr=%lx R=%lx F=%lx\n",

				pr_notice("VC:  - R=%lx F=%lx\n",

					  a->probed, a->responded, a->failed);

					  a->responded, a->failed);

				if (a == vc->ac.alist)

				if (a == vc->ac.alist)

					pr_notice("VC:  - current\n");

					pr_notice("VC:  - current\n");

			}

			}

CRA Git | Maintained and supported by SUSTech CRA and CCSE