Commit be4cf718 authored May 13, 2020 by Sascha Hauer Committed by Vinod Koul May 15, 2020

dmaengine: imx-sdma: initialize all script addresses



The script addresses array increases with each new version. The driver
initializes the array to -EINVAL initially, but only up to the size
of the v1 array. Initialize the additional addresses for the newer
versions as well. Without this uninitialized values of the newer arrays
are treated as valid.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Robin Gong <yibin.gong@nxp.com>
Link: https://lore.kernel.org/r/20200513060405.18685-1-s.hauer@pengutronix.de


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 7ae6d7bd

drivers/dma/imx-sdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2063,7 +2063,7 @@ static int sdma_probe(struct platform_device *pdev)

		/* initially no scripts available */
		saddr_arr = (s32 *)sdma->script_addrs;
		for (i = 0; i < SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1; i++)
		for (i = 0; i < sizeof(*sdma->script_addrs) / sizeof(s32); i++)
		saddr_arr[i] = -EINVAL;

		dma_cap_set(DMA_SLAVE, sdma->dma_device.cap_mask);

Admin message