Commit be2d107f authored Feb 09, 2016 by Krzysztof Adamski Committed by Linus Walleij Feb 11, 2016

pinctrl: sunxi: Use pin number when calling sunxi_pmx_set



sunxi_pmx_set accepts pin number and then calculates offset by
subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
gets offset so we have to convert it to pin number so we won't get
negative value in sunxi_pmx_set.

This was only used on A10 so far, where there is only one GPIO chip with
pin_base set to 0 so it didn't matter. However H3 also requires this
workaround but have two pinmux sections, triggering problem for PL port.

Signed-off-by: Krzysztof Adamski <k@japko.eu>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent ba83a111

drivers/pinctrl/sunxi/pinctrl-sunxi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -459,15 +459,16 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset)
		u8 index = sunxi_data_offset(offset);
		u32 set_mux = pctl->desc->irq_read_needs_mux &&
		test_bit(FLAG_USED_AS_IRQ, &chip->desc[offset].flags);
		u32 pin = offset + chip->base;
		u32 val;

		if (set_mux)
		sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_INPUT);
		sunxi_pmx_set(pctl->pctl_dev, pin, SUN4I_FUNC_INPUT);

		val = (readl(pctl->membase + reg) >> index) & DATA_PINS_MASK;

		if (set_mux)
		sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_IRQ);
		sunxi_pmx_set(pctl->pctl_dev, pin, SUN4I_FUNC_IRQ);

		return !!val;
		}

Admin message