Commit be1aa03b authored Apr 07, 2014 by Joonsoo Kim Committed by Linus Torvalds Apr 07, 2014

mm/compaction: change the timing to check to drop the spinlock



It is odd to drop the spinlock when we scan (SWAP_CLUSTER_MAX - 1) th
pfn page.  This may results in below situation while isolating
migratepage.

1. try isolate 0x0 ~ 0x200 pfn pages.
2. When low_pfn is 0x1ff, ((low_pfn+1) % SWAP_CLUSTER_MAX) == 0, so drop
   the spinlock.
3. Then, to complete isolating, retry to aquire the lock.

I think that it is better to use SWAP_CLUSTER_MAX th pfn for checking the
criteria about dropping the lock.  This has no harm 0x0 pfn, because, at
this time, locked variable would be false.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 01ead534

mm/compaction.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -487,7 +487,7 @@ isolate_migratepages_range(struct zone zone, struct compact_control cc,
		cond_resched();
		for (; low_pfn < end_pfn; low_pfn++) {
		/* give a chance to irqs before checking need_resched() */
		if (locked && !((low_pfn+1) % SWAP_CLUSTER_MAX)) {
		if (locked && !(low_pfn % SWAP_CLUSTER_MAX)) {
		if (should_release_lock(&zone->lru_lock)) {
		spin_unlock_irqrestore(&zone->lru_lock, flags);
		locked = false;

Admin message