Commit be1a71a1 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

iwlwifi: device tracing 



In order to have an easier way to debug issues, create
trace events (using the ftrace framework) that will
allow us to follow exactly what the driver is doing
with the device.

The text format isn't all that useful, but the binary
format can also be obtained easily via debugfs and
then analysed on the fly or offline with debugging
tools.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4d80d721

drivers/net/wireless/iwlwifi/Kconfig

+18 −0
Original line number Diff line number Diff line
@@ -49,6 +49,24 @@ config IWLWIFI_DEBUGFS 
        ---help---

	  Enable creation of debugfs files for the iwlwifi drivers.



config IWLWIFI_DEVICE_TRACING

	bool "iwlwifi device access tracing"

	depends on IWLWIFI

	depends on EVENT_TRACING

	help

	  Say Y here to trace all commands, including TX frames and IO

	  accesses, sent to the device. If you say yes, iwlwifi will

	  register with the ftrace framework for event tracing and dump

	  all this information to the ringbuffer, you may need to

	  increase the ringbuffer size. See the ftrace documentation

	  for more information.



	  When tracing is not enabled, this option still has some

	  (though rather small) overhead.



	  If unsure, say Y so we can help you better when problems

	  occur.



config IWLAGN

	tristate "Intel Wireless WiFi Next Gen AGN (iwlagn)"

	depends on IWLWIFI

drivers/net/wireless/iwlwifi/Makefile

+5 −2
Original line number Diff line number Diff line
@@ -5,7 +5,11 @@ iwlcore-objs += iwl-scan.o 
iwlcore-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o

iwlcore-$(CONFIG_IWLWIFI_LEDS) += iwl-led.o

iwlcore-$(CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT) += iwl-spectrum.o

iwlcore-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o



CFLAGS_iwl-devtrace.o := -I$(src)



# AGN

obj-$(CONFIG_IWLAGN)	+= iwlagn.o

iwlagn-objs		:= iwl-agn.o iwl-agn-rs.o
@@ -14,7 +18,6 @@ iwlagn-$(CONFIG_IWL5000) += iwl-5000.o 
iwlagn-$(CONFIG_IWL5000) += iwl-6000.o

iwlagn-$(CONFIG_IWL5000) += iwl-1000.o



# 3945

obj-$(CONFIG_IWL3945)	+= iwl3945.o

iwl3945-objs		:= iwl3945-base.o iwl-3945.o iwl-3945-rs.o iwl-3945-led.o

drivers/net/wireless/iwlwifi/iwl-agn.c

+8 −0
Original line number Diff line number Diff line
@@ -791,6 +791,9 @@ void iwl_rx_handle(struct iwl_priv *priv) 
				 PCI_DMA_FROMDEVICE);

		pkt = (struct iwl_rx_packet *)rxb->skb->data;



		trace_iwlwifi_dev_rx(priv, pkt,

			le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_FRAME_SIZE_MSK);



		/* Reclaim a command buffer only if this packet is a response

		 *   to a (driver-originated) command.

		 * If the packet (e.g. Rx frame) originated from uCode,
@@ -1610,6 +1613,9 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv) 
	line = iwl_read_targ_mem(priv, base + 9 * sizeof(u32));

	time = iwl_read_targ_mem(priv, base + 11 * sizeof(u32));



	trace_iwlwifi_dev_ucode_error(priv, desc, time, data1, data2, line,

				      blink1, blink2, ilink1, ilink2);



	IWL_ERR(priv, "Desc                               Time       "

		"data1      data2      line\n");

	IWL_ERR(priv, "%-28s (#%02d) %010u 0x%08X 0x%08X %u\n",
@@ -1658,12 +1664,14 @@ static void iwl_print_event_log(struct iwl_priv *priv, u32 start_idx, 
		ptr += sizeof(u32);

		if (mode == 0) {

			/* data, ev */

			trace_iwlwifi_dev_ucode_event(priv, 0, time, ev);

			IWL_ERR(priv, "EVT_LOG:0x%08x:%04u\n", time, ev);

		} else {

			data = iwl_read_targ_mem(priv, ptr);

			ptr += sizeof(u32);

			IWL_ERR(priv, "EVT_LOGT:%010u:0x%08x:%04u\n",

					time, data, ev);

			trace_iwlwifi_dev_ucode_event(priv, time, data, ev);

		}

	}

}

drivers/net/wireless/iwlwifi/iwl-devtrace.c

0 → 100644
+13 −0
Original line number Diff line number Diff line 
#include <linux/module.h>



/* sparse doesn't like tracepoint macros */

#ifndef __CHECKER__

#define CREATE_TRACE_POINTS

#include "iwl-devtrace.h"



EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_ioread32);

EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_iowrite32);

EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_rx);

EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_ucode_event);

EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_ucode_error);

#endif

drivers/net/wireless/iwlwifi/iwl-devtrace.h

0 → 100644
+178 −0
Original line number Diff line number Diff line 
#if !defined(__IWLWIFI_DEVICE_TRACE) || defined(TRACE_HEADER_MULTI_READ)

#define __IWLWIFI_DEVICE_TRACE



#include <linux/tracepoint.h>

#include "iwl-dev.h"



#if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__)

#undef TRACE_EVENT

#define TRACE_EVENT(name, proto, ...) \

static inline void trace_ ## name(proto) {}

#endif



#define PRIV_ENTRY	__field(struct iwl_priv *, priv)

#define PRIV_ASSIGN	__entry->priv = priv



#undef TRACE_SYSTEM

#define TRACE_SYSTEM iwlwifi



TRACE_EVENT(iwlwifi_dev_ioread32,

	TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val),

	TP_ARGS(priv, offs, val),

	TP_STRUCT__entry(

		PRIV_ENTRY

		__field(u32, offs)

		__field(u32, val)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		__entry->offs = offs;

		__entry->val = val;

	),

	TP_printk("[%p] read io[%#x] = %#x", __entry->priv, __entry->offs, __entry->val)

);



TRACE_EVENT(iwlwifi_dev_iowrite32,

	TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val),

	TP_ARGS(priv, offs, val),

	TP_STRUCT__entry(

		PRIV_ENTRY

		__field(u32, offs)

		__field(u32, val)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		__entry->offs = offs;

		__entry->val = val;

	),

	TP_printk("[%p] write io[%#x] = %#x)", __entry->priv, __entry->offs, __entry->val)

);



TRACE_EVENT(iwlwifi_dev_hcmd,

	TP_PROTO(struct iwl_priv *priv, void *hcmd, size_t len, u32 flags),

	TP_ARGS(priv, hcmd, len, flags),

	TP_STRUCT__entry(

		PRIV_ENTRY

		__dynamic_array(u8, hcmd, len)

		__field(u32, flags)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		memcpy(__get_dynamic_array(hcmd), hcmd, len);

		__entry->flags = flags;

	),

	TP_printk("[%p] hcmd %#.2x (%ssync)",

		  __entry->priv, ((u8 *)__get_dynamic_array(hcmd))[0],

		  __entry->flags & CMD_ASYNC ? "a" : "")

);



TRACE_EVENT(iwlwifi_dev_rx,

	TP_PROTO(struct iwl_priv *priv, void *rxbuf, size_t len),

	TP_ARGS(priv, rxbuf, len),

	TP_STRUCT__entry(

		PRIV_ENTRY

		__dynamic_array(u8, rxbuf, len)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		memcpy(__get_dynamic_array(rxbuf), rxbuf, len);

	),

	TP_printk("[%p] RX cmd %#.2x",

		  __entry->priv, ((u8 *)__get_dynamic_array(rxbuf))[4])

);



TRACE_EVENT(iwlwifi_dev_tx,

	TP_PROTO(struct iwl_priv *priv, void *tfd, size_t tfdlen,

		 void *buf0, size_t buf0_len,

		 void *buf1, size_t buf1_len),

	TP_ARGS(priv, tfd, tfdlen, buf0, buf0_len, buf1, buf1_len),

	TP_STRUCT__entry(

		PRIV_ENTRY



		__field(size_t, framelen)

		__dynamic_array(u8, tfd, tfdlen)



		/*

		 * Do not insert between or below these items,

		 * we want to keep the frame together (except

		 * for the possible padding).

		 */

		__dynamic_array(u8, buf0, buf0_len)

		__dynamic_array(u8, buf1, buf1_len)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		__entry->framelen = buf0_len + buf1_len;

		memcpy(__get_dynamic_array(tfd), tfd, tfdlen);

		memcpy(__get_dynamic_array(buf0), buf0, buf0_len);

		memcpy(__get_dynamic_array(buf1), buf1, buf0_len);

	),

	TP_printk("[%p] TX %.2x (%zu bytes)",

		  __entry->priv,

		  ((u8 *)__get_dynamic_array(buf0))[0],

		  __entry->framelen)

);



TRACE_EVENT(iwlwifi_dev_ucode_error,

	TP_PROTO(struct iwl_priv *priv, u32 desc, u32 time,

		 u32 data1, u32 data2, u32 line, u32 blink1,

		 u32 blink2, u32 ilink1, u32 ilink2),

	TP_ARGS(priv, desc, time, data1, data2, line,

		blink1, blink2, ilink1, ilink2),

	TP_STRUCT__entry(

		PRIV_ENTRY

		__field(u32, desc)

		__field(u32, time)

		__field(u32, data1)

		__field(u32, data2)

		__field(u32, line)

		__field(u32, blink1)

		__field(u32, blink2)

		__field(u32, ilink1)

		__field(u32, ilink2)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		__entry->desc = desc;

		__entry->time = time;

		__entry->data1 = data1;

		__entry->data2 = data2;

		__entry->line = line;

		__entry->blink1 = blink1;

		__entry->blink2 = blink2;

		__entry->ilink1 = ilink1;

		__entry->ilink2 = ilink2;

	),

	TP_printk("[%p] #%02d %010u data 0x%08X 0x%08X line %u, "

		  "blink 0x%05X 0x%05X ilink 0x%05X 0x%05X",

		  __entry->priv, __entry->desc, __entry->time, __entry->data1,

		  __entry->data2, __entry->line, __entry->blink1,

		  __entry->blink2, __entry->ilink1, __entry->ilink2)

);



TRACE_EVENT(iwlwifi_dev_ucode_event,

	TP_PROTO(struct iwl_priv *priv, u32 time, u32 data, u32 ev),

	TP_ARGS(priv, time, data, ev),

	TP_STRUCT__entry(

		PRIV_ENTRY



		__field(u32, time)

		__field(u32, data)

		__field(u32, ev)

	),

	TP_fast_assign(

		PRIV_ASSIGN;

		__entry->time = time;

		__entry->data = data;

		__entry->ev = ev;

	),

	TP_printk("[%p] EVT_LOGT:%010u:0x%08x:%04u",

		  __entry->priv, __entry->time, __entry->data, __entry->ev)

);

#endif /* __IWLWIFI_DEVICE_TRACE */



#undef TRACE_INCLUDE_PATH

#define TRACE_INCLUDE_PATH .

#undef TRACE_INCLUDE_FILE

#define TRACE_INCLUDE_FILE iwl-devtrace

#include <trace/define_trace.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE