Commit bdfad5ae authored May 10, 2019 by Tobin C. Harding Committed by David S. Miller May 10, 2019

bridge: Fix error path for kobject_init_and_add()

Currently error return from kobject_init_and_add() is not followed by a
call to kobject_put(). This means there is a memory leak. We currently
set p to NULL so that kfree() may be called on it as a noop, the code is
arguably clearer if we move the kfree() up closer to where it is
called (instead of after goto jump).

Remove a goto label 'err1' and jump to call to kobject_put() in error
return from kobject_init_and_add() fixing the memory leak. Re-name goto
label 'put_back' to 'err1' now that we don't use err1, following current
nomenclature (err1, err2 ...). Move call to kfree out of the error
code at bottom of function up to closer to where memory was allocated.
Add comment to clarify call to kfree().

Signed-off-by: Tobin C. Harding <tobin@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e711ab93

net/bridge/br_if.c

+6 −7

Original line number	Diff line number	Diff line
		@@ -602,13 +602,15 @@ int br_add_if(struct net_bridge br, struct net_device dev,
		call_netdevice_notifiers(NETDEV_JOIN, dev);

		err = dev_set_allmulti(dev, 1);
		if (err)
		goto put_back;
		if (err) {
		kfree(p); /* kobject not yet init'd, manually free */
		goto err1;
		}

		err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj),
		SYSFS_BRIDGE_PORT_ATTR);
		if (err)
		goto err1;
		goto err2;

		err = br_sysfs_addif(p);
		if (err)
		@@ -700,12 +702,9 @@ err3:
		sysfs_remove_link(br->ifobj, p->dev->name);
		err2:
		kobject_put(&p->kobj);
		p = NULL; /* kobject_put frees */
		err1:
		dev_set_allmulti(dev, -1);
		put_back:
		err1:
		dev_put(dev);
		kfree(p);
		return err;
		}

Admin message