Commit bdf2f59e authored Aug 06, 2016 by Paul Gortmaker Committed by David S. Miller Sep 28, 2016

sparc64: fix section mismatch in find_numa_latencies_for_group



To fix:

  WARNING: vmlinux.o(.text.unlikely+0x580): Section mismatch in
  reference from the function find_numa_latencies_for_group() to the
  function .init.text:find_mlgroup()

  The function find_numa_latencies_for_group() references the
  function __init find_mlgroup().  This is often because
  find_numa_latencies_for_group lacks a __init annotation or the
  annotation of find_mlgroup is wrong.

It turns out find_numa_latencies_for_group is only called from:
    static int __init numa_parse_mdesc(void)
and hence we can tag find_numa_latencies_for_group with __init.

In doing so we see that find_best_numa_node_for_mlgroup is only
called from within __init and hence can also be marked with __init.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Nitin Gupta <nitin.m.gupta@oracle.com>
Cc: Chris Hyser <chris.hyser@oracle.com>
Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8ab293e3

arch/sparc/mm/init_64.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1160,7 +1160,7 @@ int __node_distance(int from, int to)
		return numa_latency[from][to];
		}

		static int find_best_numa_node_for_mlgroup(struct mdesc_mlgroup *grp)
		static int __init find_best_numa_node_for_mlgroup(struct mdesc_mlgroup *grp)
		{
		int i;

		@@ -1173,8 +1173,8 @@ static int find_best_numa_node_for_mlgroup(struct mdesc_mlgroup *grp)
		return i;
		}

		static void find_numa_latencies_for_group(struct mdesc_handle *md, u64 grp,
		int index)
		static void __init find_numa_latencies_for_group(struct mdesc_handle *md,
		u64 grp, int index)
		{
		u64 arc;

Admin message