Commit bde3e706 authored Nov 03, 2014 by Andy Shevchenko Committed by Lee Jones Nov 25, 2014

mfd: lpc_sch: Don't call mfd_remove_devices()



MFD core already cares about failing registration. It will remove successfully
registered devices in case of error. Thus, no need to repeatedly call
mfd_remove_devices().

Fixes: 5829e9b6 (mfd: lpc_sch: Accomodate partial population of the MFD devices)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 1753b40f

drivers/mfd/lpc_sch.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev dev, const struct pci_device_id id)
		return -ENODEV;
		}

		ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
		if (ret)
		mfd_remove_devices(&dev->dev);

		return ret;
		return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
		}

		static void lpc_sch_remove(struct pci_dev *dev)

Admin message