Commit bde1b56f authored Mar 30, 2020 by Xin Long Committed by David S. Miller Mar 30, 2020

udp: initialize is_flist with 0 in udp_gro_receive



Without NAPI_GRO_CB(skb)->is_flist initialized, when the dev doesn't
support NETIF_F_GRO_FRAGLIST, is_flist can still be set and fraglist
will be used in udp_gro_receive().

So fix it by initializing is_flist with 0 in udp_gro_receive.

Fixes: 9fd1ff5d ("udp: Support UDP fraglist GRO/GSO.")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 25629fda

net/ipv4/udp_offload.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -453,6 +453,7 @@ struct sk_buff udp_gro_receive(struct list_head head, struct sk_buff *skb,
		unsigned int off = skb_gro_offset(skb);
		int flush = 1;

		NAPI_GRO_CB(skb)->is_flist = 0;
		if (skb->dev->features & NETIF_F_GRO_FRAGLIST)
		NAPI_GRO_CB(skb)->is_flist = sk ? !udp_sk(sk)->gro_enabled: 1;

Admin message