Commit bdb6bc06 authored Jan 24, 2013 by Alan Stern Committed by Greg Kroah-Hartman Jan 24, 2013

USB: fix sign-extension bug in the hub driver



This patch (as1646) fixes a long-standing bug in the USB hub driver.
Upon conversion from char to unsigned long, the bytes in the status
buffer are subject to unwanted sign extension.  The bytes should be
declared as u8 rather than char, to prevent this.

This effects of this bug are minimal.  The hub driver may end up doing
a little unnecessary extra work because it thinks events have occurred
on some ports when they really haven't.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3171fcab

drivers/usb/core/hub.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -31,7 +31,7 @@ struct usb_hub {
		struct urb urb; / for interrupt polling pipe */

		/* buffer for urb ... with extra space in case of babble */
		char (*buffer)[8];
		u8 (*buffer)[8];
		union {
		struct usb_hub_status hub;
		struct usb_port_status port;

Admin message