Commit bd6d4db5 authored Jan 07, 2015 by Ying Xue Committed by David S. Miller Jan 08, 2015

rhashtable: future table needs to be traversed when remove an object



When remove an object from hash table, we currently only traverse old
bucket table to check whether the object exists. If the object is not
found in it, we will try again. But in the second search loop, we still
search the object from the old table instead of future table. As a
result, the object may be not removed from hash table especially when
resizing is currently in progress and the object is just saved in the
future table.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Cc: Thomas Graf <tgraf@suug.ch>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent db304854

lib/rhashtable.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -608,10 +608,10 @@ restart:
		return true;
		}

		if (tbl != rht_dereference_rcu(ht->tbl, ht)) {
		if (tbl != rht_dereference_rcu(ht->future_tbl, ht)) {
		spin_unlock_bh(lock);

		tbl = rht_dereference_rcu(ht->tbl, ht);
		tbl = rht_dereference_rcu(ht->future_tbl, ht);
		hash = head_hashfn(ht, tbl, obj);

		lock = bucket_lock(tbl, hash);

Admin message