Commit bd6227a1 authored Sep 14, 2017 by Stephan Mueller Committed by Herbert Xu Sep 20, 2017

crypto: drbg - fix freeing of resources



During the change to use aligned buffers, the deallocation code path was
not updated correctly. The current code tries to free the aligned buffer
pointer and not the original buffer pointer as it is supposed to.

Thus, the code is updated to free the original buffer pointer and set
the aligned buffer pointer that is used throughout the code to NULL.

Fixes: 3cfc3b97 ("crypto: drbg - use aligned buffers")
CC: <stable@vger.kernel.org>
CC: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 2bd6bf03

crypto/drbg.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1133,10 +1133,10 @@ static inline void drbg_dealloc_state(struct drbg_state *drbg)
		{
		if (!drbg)
		return;
		kzfree(drbg->V);
		drbg->Vbuf = NULL;
		kzfree(drbg->C);
		drbg->Cbuf = NULL;
		kzfree(drbg->Vbuf);
		drbg->V = NULL;
		kzfree(drbg->Cbuf);
		drbg->C = NULL;
		kzfree(drbg->scratchpadbuf);
		drbg->scratchpadbuf = NULL;
		drbg->reseed_ctr = 0;

Admin message