Commit bd5d6781 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Use __ffs() in for_each_priolist for more compact code 



Gcc has a slight preference if we use __ffs() to subtract one from the
index once rather than each use:

__execlists_submission_tasklet              2867    2847     -20

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190226102404.29153-11-chris@chris-wilson.co.uk
parent d9948a10

drivers/gpu/drm/i915/i915_scheduler.h

+4 −2
Original line number Diff line number Diff line
@@ -95,9 +95,11 @@ struct i915_priolist { 
		list_for_each_entry(it, &(plist)->requests[idx], sched.link)



#define priolist_for_each_request_consume(it, n, plist, idx) \

	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \

	for (; \

	     (plist)->used ? (idx = __ffs((plist)->used)), 1 : 0; \

	     (plist)->used &= ~BIT(idx)) \

		list_for_each_entry_safe(it, n, \

					 &(plist)->requests[idx - 1], \

					 &(plist)->requests[idx], \

					 sched.link)



void i915_sched_node_init(struct i915_sched_node *node);

CRA Git | Maintained and supported by SUSTech CRA and CCSE