Commit bd4b9683 authored Nov 21, 2013 by Aristeu Rozanski Committed by Borislav Petkov Nov 30, 2013

sb_edac: Shut up compiler warning when EDAC_DEBUG is enabled



Fix this:

In file included from drivers/edac/sb_edac.c:27:0:
drivers/edac/sb_edac.c: In function ‘sbridge_mce_output_error’:
drivers/edac/edac_core.h:50:8: warning: ‘limit’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  printk(level "EDAC " prefix ": " fmt, ##arg)
        ^
drivers/edac/sb_edac.c:948:25: note: ‘limit’ was declared here
  u64   ch_addr, offset, limit, prv = 0;

Limit can be initialized to 0. The only way limit wouldn't be
initialized is if there are no DIMMs present (which would be a bug of
course) and it'd fail on the next test.

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Link: http://lkml.kernel.org/r/20131121122021.GD26009@pd.tnic


Signed-off-by: Borislav Petkov <bp@suse.de>

parent dc1ccc48

drivers/edac/sb_edac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -945,7 +945,7 @@ static int get_memory_error_data(struct mem_ctl_info *mci,
		u32 tad_offset;
		u32 rir_way;
		u32 mb, kb;
		u64 ch_addr, offset, limit, prv = 0;
		u64 ch_addr, offset, limit = 0, prv = 0;


		/*

Admin message