Commit bd49111f authored Feb 06, 2018 by Joe Perches Committed by Linus Torvalds Feb 06, 2018

checkpatch: avoid some false positives for TABSTOP declaration test

Using an open bracket after what seems to be a declaration can also be a
function definition and declaration argument line continuation so remove
the open bracket from the possible declaration/definition matching.

e.g.:
	int foobar(int a;
		   int *b[]);

Link: http://lkml.kernel.org/r/1515704479.9619.171.camel@perches.com


Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a032aa4c

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -3020,7 +3020,7 @@ sub process {

		# check indentation starts on a tab stop
		if ($^V && $^V ge 5.10.0 &&
		$sline =~ /^\+\t+( +)(?:$c90_Keywords\b\|\{\s$\|\}\s(?:else\b\|while\b\|\s$)\|$Declare\s$Ident\s*[;=\[])/) {
		$sline =~ /^\+\t+( +)(?:$c90_Keywords\b\|\{\s$\|\}\s(?:else\b\|while\b\|\s$)\|$Declare\s$Ident\s*[;=])/) {
		my $indent = length($1);
		if ($indent % 8) {
		if (WARN("TABSTOP",

Admin message