Commit bd3486de authored Dec 05, 2017 by Bin Liu Committed by Greg Kroah-Hartman Dec 08, 2017

usb: musb: da8xx: fix babble condition handling



When babble condition happens, the musb controller might automatically
turns off VBUS. On DA8xx platform, the controller generates drvvbus
interrupt for turning off VBUS along with the babble interrupt.

In this case, we should handle the babble interrupt first and recover
from the babble condition.

This change ignores the drvvbus interrupt if babble interrupt is also
generated at the same time, so the babble recovery routine works
properly.

Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6b0b3bda

drivers/usb/musb/da8xx.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -284,7 +284,15 @@ static irqreturn_t da8xx_musb_interrupt(int irq, void *hci)
		musb->xceiv->otg->state = OTG_STATE_A_WAIT_VRISE;
		portstate(musb->port1_status \|= USB_PORT_STAT_POWER);
		del_timer(&musb->dev_timer);
		} else {
		} else if (!(musb->int_usb & MUSB_INTR_BABBLE)) {
		/*
		* When babble condition happens, drvvbus interrupt
		* is also generated. Ignore this drvvbus interrupt
		* and let babble interrupt handler recovers the
		* controller; otherwise, the host-mode flag is lost
		* due to the MUSB_DEV_MODE() call below and babble
		* recovery logic will not be called.
		*/
		musb->is_active = 0;
		MUSB_DEV_MODE(musb);
		otg->default_a = 0;

Admin message