Commit bd25b488 authored by Daniel Jordan's avatar Daniel Jordan Committed by Herbert Xu
Browse files

padata: remove start function 



padata_start() is only used right after pcrypt allocates an instance
with all possible CPUs, when PADATA_INVALID can't happen, so there's no
need for a separate "start" step.  It can be done during allocation to
save text, make using padata easier, and avoid unneeded calls in the
future.

Signed-off-by: default avatarDaniel Jordan <daniel.m.jordan@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent c06c7660

crypto/pcrypt.c

+0 −3
Original line number Diff line number Diff line
@@ -355,9 +355,6 @@ static int __init pcrypt_init(void) 
	if (err)

		goto err_deinit_pencrypt;



	padata_start(pencrypt);

	padata_start(pdecrypt);



	return crypto_register_template(&pcrypt_tmpl);



err_deinit_pencrypt:

include/linux/padata.h

+0 −1
Original line number Diff line number Diff line
@@ -204,6 +204,5 @@ extern void padata_do_serial(struct padata_priv *padata); 
extern void __init padata_do_multithreaded(struct padata_mt_job *job);

extern int padata_set_cpumask(struct padata_instance *pinst, int cpumask_type,

			      cpumask_var_t cpumask);

extern int padata_start(struct padata_instance *pinst);

extern void padata_stop(struct padata_instance *pinst);

#endif

kernel/padata.c

+1 −25
Original line number Diff line number Diff line
@@ -789,30 +789,6 @@ out: 
}

EXPORT_SYMBOL(padata_set_cpumask);



/**

 * padata_start - start the parallel processing

 *

 * @pinst: padata instance to start

 *

 * Return: 0 on success or negative error code

 */

int padata_start(struct padata_instance *pinst)

{

	int err = 0;



	mutex_lock(&pinst->lock);



	if (pinst->flags & PADATA_INVALID)

		err = -EINVAL;



	__padata_start(pinst);



	mutex_unlock(&pinst->lock);



	return err;

}

EXPORT_SYMBOL(padata_start);



/**

 * padata_stop - stop the parallel processing

 *
@@ -1100,7 +1076,7 @@ static struct padata_instance *padata_alloc(const char *name, 
	if (padata_setup_cpumasks(pinst))

		goto err_free_rcpumask_cbcpu;



	pinst->flags = 0;

	__padata_start(pinst);



	kobject_init(&pinst->kobj, &padata_attr_type);

	mutex_init(&pinst->lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE