Commit bd007bea authored May 07, 2012 by H Hartley Sweeten Committed by John W. Linville May 15, 2012

NFC: HCI ops should not be exposed globally



The variable 'hci_nfc_ops' is only referenced in this file and
should be marked static to prevent it from being exposed globally.

Quites the sparse warning:

warning: symbol 'hci_nfc_ops' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 799030b7

net/nfc/hci/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -585,7 +585,7 @@ static int hci_check_presence(struct nfc_dev *nfc_dev,
		return 0;
		}

		struct nfc_ops hci_nfc_ops = {
		static struct nfc_ops hci_nfc_ops = {
		.dev_up = hci_dev_up,
		.dev_down = hci_dev_down,
		.start_poll = hci_start_poll,

Admin message