Commit bcfcb7f9 authored Jan 10, 2020 by Johan Hovold Committed by Dmitry Torokhov Jan 10, 2020

Input: pegasus_notetaker - fix endpoint sanity check



The driver was checking the number of endpoints of the first alternate
setting instead of the current one, something which could be used by a
malicious device (or USB descriptor fuzzer) to trigger a NULL-pointer
dereference.

Fixes: 1afca2b6 ("Input: add Pegasus Notetaker tablet driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Martin Kepplinger <martink@posteo.de>
Acked-by: Vladis Dronov <vdronov@redhat.com>
Link: https://lore.kernel.org/r/20191210113737.4016-2-johan@kernel.org


Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 97e24b09

drivers/input/tablet/pegasus_notetaker.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -275,7 +275,7 @@ static int pegasus_probe(struct usb_interface *intf,
	return -ENODEV;		return -ENODEV;

	/* Sanity check that the device has an endpoint */		/* Sanity check that the device has an endpoint */
	if (intf->altsetting[0].desc.bNumEndpoints < 1) {		if (intf->cur_altsetting->desc.bNumEndpoints < 1) {
	dev_err(&intf->dev, "Invalid number of endpoints\n");		dev_err(&intf->dev, "Invalid number of endpoints\n");
	return -EINVAL;		return -EINVAL;
	}		}

Admin message