floppy: make local variable non-static (bcf4299e) · Commits · 戴 / test

There's no reason for temparea to be static, since it's only used for temporary sprintf output. It's not immediately obvious that the output will always fit (in the worst case, the output including '\0' is exactly 32 bytes), so save a future reader from worrying about that. Signed-off-by:

Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:

Jiri Kosina <jkosina@suse.cz>

drivers/block/floppy.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3585,7 +3585,7 @@ static void __init config_types(void)
		unsigned int type = UDP->cmos;
		struct floppy_drive_params *params;
		const char *name = NULL;
		static char temparea[32];
		char temparea[32];

		if (type < ARRAY_SIZE(default_drive_params)) {
		params = &default_drive_params[type].params;
		@@ -3596,7 +3596,8 @@ static void __init config_types(void)
		allowed_drive_mask &= ~(1 << drive);
		} else {
		params = &default_drive_params[0].params;
		sprintf(temparea, "unknown type %d (usb?)", type);
		snprintf(temparea, sizeof(temparea),
		"unknown type %d (usb?)", type);
		name = temparea;
		}
		if (name) {

Admin message