Commit bceb418b authored Aug 19, 2019 by Nishka Dasgupta Committed by Felipe Balbi Aug 28, 2019

usb: dwc3: st: Add of_dev_put() in probe function



In function st_dwc3_probe, variable child_pdev takes the value returned
by of_find_device_by_node, which gets a device pointer but does not put
it. If child_pdev is not put before the probe function returns, it may
cause a reference leak. Hence put child_pdev after its last usage.
Issue found with Coccinelle.

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent e36721b9

drivers/usb/dwc3/dwc3-st.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -274,6 +274,7 @@ static int st_dwc3_probe(struct platform_device *pdev)

		dwc3_data->dr_mode = usb_get_dr_mode(&child_pdev->dev);
		of_node_put(child);
		of_dev_put(child_pdev);

		/*
		* Configure the USB port as device or host according to the static

Admin message