Commit bce85a16 authored Oct 31, 2018 by Breno Leitao Committed by Michael Ellerman Nov 25, 2018

powerpc/mm: Remove extern from function definition

Function huge_ptep_set_access_flags() has the 'extern' keyword in the
function definition and also in the function declaration. This causes a
warning in 'sparse' since the 'extern' storage class should not be used
in the function definition.

arch/powerpc/mm/pgtable.c:232:12: warning: function 'huge_ptep_set_access_flags' with external linkage has definition

This patch removes the keyword from the definition part. It also removes
the extern keyword from the declaration part, since checkpatch --strict
complains about it.

Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 71432ce2

arch/powerpc/include/asm/hugetlb.h

+3 −3

Original line number	Diff line number	Diff line
		@@ -135,7 +135,7 @@ static inline void huge_ptep_clear_flush(struct vm_area_struct *vma,
		}

		#define __HAVE_ARCH_HUGE_PTEP_SET_ACCESS_FLAGS
		extern int huge_ptep_set_access_flags(struct vm_area_struct *vma,
		int huge_ptep_set_access_flags(struct vm_area_struct *vma,
		unsigned long addr, pte_t *ptep,
		pte_t pte, int dirty);

arch/powerpc/mm/pgtable.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -221,7 +221,7 @@ int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address,
		}

		#ifdef CONFIG_HUGETLB_PAGE
		extern int huge_ptep_set_access_flags(struct vm_area_struct *vma,
		int huge_ptep_set_access_flags(struct vm_area_struct *vma,
		unsigned long addr, pte_t *ptep,
		pte_t pte, int dirty)
		{

Admin message