Commit bcdee04e authored Sep 13, 2012 by Jiri Slaby Committed by Greg Kroah-Hartman Sep 26, 2012

MISC: hpilo, remove pci_disable_device

pci_disable_device(pdev) used to be in pci remove function. But this
PCI device has two functions with interrupt lines connected to a
single pin. The other one is a USB host controller. So when we disable
the PIN there e.g. by rmmod hpilo, the controller stops working. It is
because the interrupt link is disabled in ACPI since it is not
refcounted yet. See acpi_pci_link_free_irq called from
acpi_pci_irq_disable.

It is not the best solution whatsoever, but as a workaround until the
ACPI irq link refcounting is sorted out this should fix the reported
errors.

References: https://lkml.org/lkml/2008/11/4/535



Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Nobin Mathew <nobin.mathew@gmail.com>
Cc: Robert Hancock <hancockr@shaw.ca>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: David Altobelli <david.altobelli@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 221b7b57

drivers/misc/hpilo.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -736,7 +736,14 @@ static void ilo_remove(struct pci_dev *pdev)
		free_irq(pdev->irq, ilo_hw);
		ilo_unmap_device(pdev, ilo_hw);
		pci_release_regions(pdev);
		pci_disable_device(pdev);
		/*
		* pci_disable_device(pdev) used to be here. But this PCI device has
		* two functions with interrupt lines connected to a single pin. The
		* other one is a USB host controller. So when we disable the PIN here
		* e.g. by rmmod hpilo, the controller stops working. It is because
		* the interrupt link is disabled in ACPI since it is not refcounted
		* yet. See acpi_pci_link_free_irq called from acpi_pci_irq_disable.
		*/
		kfree(ilo_hw);
		ilo_hwdev[(minor / max_ccb)] = 0;
		}
		@@ -826,7 +833,7 @@ unmap:
		free_regions:
		pci_release_regions(pdev);
		disable:
		pci_disable_device(pdev);
		/* pci_disable_device(pdev); see comment in ilo_remove */
		free:
		kfree(ilo_hw);
		out:

Admin message