Commit bcdedcc1 authored by Wengmeiling's avatar Wengmeiling Committed by Linus Torvalds
Browse files

menuconfig: print more info for symbol without prompts 



When we search a config symbol, if it has no prompt the position of this
symbol in the Kconfig file and it's dependencies are not printed.  This
can be inconvenient, especially when it's set to n and we want to find out
why.

the following is an example:

before:

Symbol: GENERIC_SMP_IDLE_THREAD [=y]
Type  : boolean
  Selected by: X86 [=y]

after:

Symbol: GENERIC_SMP_IDLE_THREAD [=y]
Type  : boolean
  Defined at arch/Kconfig:213
  Selected by: X86 [=y]

Signed-off-by: default avatarWeng Meiling <wengmeiling.weng@huawei.com>
Signed-off-by: default avatarLibo Chen <libo.chen@huawei.com>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 657a5209

scripts/kconfig/menu.c

+20 −7
Original line number Original line Diff line number Diff line
@@ -515,13 +515,6 @@ static void get_prompt_str(struct gstr *r, struct property *prop, 
	struct jump_key *jump;

	struct jump_key *jump;





	str_printf(r, _("Prompt: %s\n"), _(prop->text));

	str_printf(r, _("Prompt: %s\n"), _(prop->text));

	str_printf(r, _("  Defined at %s:%d\n"), prop->menu->file->name,

		prop->menu->lineno);

	if (!expr_is_yes(prop->visible.expr)) {

		str_append(r, _("  Depends on: "));

		expr_gstr_print(prop->visible.expr, r);

		str_append(r, "\n");

	}

	menu = prop->menu->parent;

	menu = prop->menu->parent;

	for (i = 0; menu != &rootmenu && i < 8; menu = menu->parent) {

	for (i = 0; menu != &rootmenu && i < 8; menu = menu->parent) {

		bool accessible = menu_is_visible(menu);

		bool accessible = menu_is_visible(menu);
@@ -571,6 +564,18 @@ static void get_prompt_str(struct gstr *r, struct property *prop, 
	}

	}

}

}





/*

 * get peoperty of type P_SYMBOL

 */

static struct property *get_symbol_prop(struct symbol *sym)

{

	struct property *prop = NULL;



	for_all_properties(sym, prop, P_SYMBOL)

		break;

	return prop;

}



/*

/*

 * head is optional and may be NULL

 * head is optional and may be NULL

 */

 */
@@ -595,6 +600,14 @@ void get_symbol_str(struct gstr *r, struct symbol *sym, 
	}

	}

	for_all_prompts(sym, prop)

	for_all_prompts(sym, prop)

		get_prompt_str(r, prop, head);

		get_prompt_str(r, prop, head);

	prop = get_symbol_prop(sym);

	str_printf(r, _("  Defined at %s:%d\n"), prop->menu->file->name,

		prop->menu->lineno);

	if (!expr_is_yes(prop->visible.expr)) {

		str_append(r, _("  Depends on: "));

		expr_gstr_print(prop->visible.expr, r);

		str_append(r, "\n");

	}

	hit = false;

	hit = false;

	for_all_properties(sym, prop, P_SELECT) {

	for_all_properties(sym, prop, P_SELECT) {

		if (!hit) {

		if (!hit) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE