Commit bcc378e7 authored Oct 29, 2008 by Geert Uytterhoeven Committed by Linus Torvalds Oct 30, 2008

rtc: ds3234 doesn't link when built-in



When ds3234 is built-in, the final links fails with the following vague error
message:

`.exit.text' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o

ds3234_remove() cannot be marked __exit, as it's accessed via __devexit_p().
In addition, mark ds3234_probe() __devinit while we're at it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 81365c31

drivers/rtc/rtc-ds3234.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -189,7 +189,7 @@ static const struct rtc_class_ops ds3234_rtc_ops = {
		.set_time = ds3234_set_time,
		};

		static int ds3234_probe(struct spi_device *spi)
		static int __devinit ds3234_probe(struct spi_device *spi)
		{
		struct rtc_device *rtc;
		unsigned char tmp;
		@@ -249,7 +249,7 @@ static int ds3234_probe(struct spi_device *spi)
		return 0;
		}

		static int __exit ds3234_remove(struct spi_device *spi)
		static int __devexit ds3234_remove(struct spi_device *spi)
		{
		struct ds3234 *chip = platform_get_drvdata(spi);
		struct rtc_device *rtc = chip->rtc;

Admin message