drm/amd/pp: Refine function iceland_start_smu (bcb7c4e8) · Commits · 戴 / test

if upload firmware failed, no matter how many times the function runs again, the same error will be encountered. so remove the duplicated code. Reviewed-by:

Evan Quan <evan.quan@amd.com> Signed-off-by:

Rex Zhu <Rex.Zhu@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c

+1 −11

Original line number	Diff line number	Diff line
		@@ -234,22 +234,12 @@ static int iceland_start_smu(struct pp_hwmgr *hwmgr)
		{
		int result;

		result = iceland_smu_upload_firmware_image(hwmgr);
		if (result)
		return result;
		result = iceland_smu_start_smc(hwmgr);
		if (result)
		return result;

		if (!smu7_is_smc_ram_running(hwmgr)) {
		pr_info("smu not running, upload firmware again \n");
		result = iceland_smu_upload_firmware_image(hwmgr);
		if (result)
		return result;

		result = iceland_smu_start_smc(hwmgr);
		if (result)
		return result;
		iceland_smu_start_smc(hwmgr);
		}

		result = smu7_request_smu_load_fw(hwmgr);

Admin message