Commit bcb3a167 authored Nov 11, 2009 by Scott Valentine Committed by Linus Torvalds Nov 12, 2009

rtc: v3020: fix v3020_mmio_read_bit()



v3020_mmio_read_bit() always returns 0 when left_shift > 7.

v3020_mmio_read_bit()'s return type is (unsigned char).  The code returns
a value masked by (1 << left_shift) that is casted to the return type.  If
left_shift is larger than 7, the cast will always result in a 0 return
value.  The problem was discovered with left_shift = 16, and the included
patch corrects the problem.

The bug was introduced in the last (Apr 3 2009) commit of the file, kernel
versions 2.6.30 and later.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
Cc: Raphael Assenat <raph@8d.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 61df3337

drivers/rtc/rtc-v3020.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -96,7 +96,7 @@ static void v3020_mmio_write_bit(struct v3020 *chip, unsigned char bit)

		static unsigned char v3020_mmio_read_bit(struct v3020 *chip)
		{
		return readl(chip->ioaddress) & (1 << chip->leftshift);
		return !!(readl(chip->ioaddress) & (1 << chip->leftshift));
		}

		static struct v3020_chip_ops v3020_mmio_ops = {

Admin message