Commit bcb38ceb authored Nov 30, 2010 by Dave Airlie Committed by Linus Torvalds Nov 29, 2010

Revert "debug_locks: set oops_in_progress if we will log messages."



This reverts commit e0fdace1.

On-list discussion seems to suggest that the robustness fixes for printk
make this unnecessary and DaveM has also agreed in person at Kernel Summit
and on list.

The main problem with this code is once we hit a lockdep splat we always
keep oops_in_progress set, the console layer uses oops_in_progress with KMS
to decide when it should be showing the oops and not showing X, so it causes
problems around suspend/resume time when a userspace resume can cause a console
switch away from X, only if oops_in_progress is set (which is what we want
if an oops actually is in progress, but not because we had a lockdep splat
2 days prior).

Cc: David S Miller <davem@davemloft.net>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8f1b1a50

lib/debug_locks.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -8,7 +8,6 @@
		*
		* Copyright (C) 2006 Red Hat, Inc., Ingo Molnar <mingo@redhat.com>
		*/
		#include <linux/kernel.h>
		#include <linux/rwsem.h>
		#include <linux/mutex.h>
		#include <linux/module.h>
		@@ -39,7 +38,6 @@ int debug_locks_off(void)
		{
		if (__debug_locks_off()) {
		if (!debug_locks_silent) {
		oops_in_progress = 1;
		console_verbose();
		return 1;
		}

Admin message