net: smc91x: Fix possible memory leak in smc_drv_probe() (bca9749b) · Commits · 戴 / test

If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) should be called to free the ndev created earlier. Otherwise, a memleak will occur. Fixes: ("net: smc91x: Fix gpios for device tree based booting") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Wang Hai <wanghai38@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/smsc/smc91x.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2274,7 +2274,7 @@ static int smc_drv_probe(struct platform_device *pdev)
		ret = try_toggle_control_gpio(&pdev->dev, &lp->power_gpio,
		"power", 0, 0, 100);
		if (ret)
		return ret;
		goto out_free_netdev;

		/*
		* Optional reset GPIO configured? Minimum 100 ns reset needed
		@@ -2283,7 +2283,7 @@ static int smc_drv_probe(struct platform_device *pdev)
		ret = try_toggle_control_gpio(&pdev->dev, &lp->reset_gpio,
		"reset", 0, 0, 100);
		if (ret)
		return ret;
		goto out_free_netdev;

		/*
		* Need to wait for optional EEPROM to load, max 750 us according

Admin message