Commit bca90082 authored Oct 24, 2019 by Uwe Kleine-König Committed by Thierry Reding Jan 20, 2020

pwm: rcar: Drop useless call to pwm_get_state()



pwm_get_state has no side effects and the resulting pwm_state is unused.
So drop the call to pwm_get_state() and the local variable from
rcar_pwm_apply().

The call was introduced in commit 7f68ce82 ("pwm: rcar: Add support
"atomic" API") and already then was useless.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent f24e5641

drivers/pwm/pwm-rcar.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -161,11 +161,9 @@ static int rcar_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
		const struct pwm_state *state)
		{
		struct rcar_pwm_chip *rp = to_rcar_pwm_chip(chip);
		struct pwm_state cur_state;
		int div, ret;

		/* This HW/driver only supports normal polarity */
		pwm_get_state(pwm, &cur_state);
		if (state->polarity != PWM_POLARITY_NORMAL)
		return -ENOTSUPP;

Admin message