Commit bca3e43c authored Dec 14, 2020 by Ionela Voinescu Committed by Rafael J. Wysocki Dec 15, 2020

ACPI: processor: fix NONE coordination for domain mapping failure



For errors parsing the _PSD domains, a separate domain is returned for
each CPU in the failed _PSD domain with no coordination (as per previous
comment). But contrary to the intention, the code was setting
CPUFREQ_SHARED_TYPE_ALL as coordination type.

Change shared_type to CPUFREQ_SHARED_TYPE_NONE in case of errors parsing
the domain information. The function still returns the error and the caller
is free to bail out the domain initialisation altogether in that case.

Given that both functions return domains with a single CPU, this change
does not affect the functionality, but clarifies the intention.

Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
[ rjw: Subject edit ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 55130fb2

drivers/acpi/cppc_acpi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -511,7 +511,7 @@ err_ret:
		/* Assume no coordination on any error parsing domain info */
		cpumask_clear(pr->shared_cpu_map);
		cpumask_set_cpu(i, pr->shared_cpu_map);
		pr->shared_type = CPUFREQ_SHARED_TYPE_ALL;
		pr->shared_type = CPUFREQ_SHARED_TYPE_NONE;
		}
		out:
		free_cpumask_var(covered_cpus);

drivers/acpi/processor_perflib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -709,7 +709,7 @@ err_ret:
		if (retval) {
		cpumask_clear(pr->performance->shared_cpu_map);
		cpumask_set_cpu(i, pr->performance->shared_cpu_map);
		pr->performance->shared_type = CPUFREQ_SHARED_TYPE_ALL;
		pr->performance->shared_type = CPUFREQ_SHARED_TYPE_NONE;
		}
		pr->performance = NULL; /* Will be set for real in register */
		}

Admin message