Commit bca37119 authored Jun 26, 2020 by Paul E. McKenney

tick-sched: Clarify "NOHZ: local_softirq_pending" warning



Currently, can_stop_idle_tick() prints "NOHZ: local_softirq_pending HH"
(where "HH" is the hexadecimal softirq vector number) when one or more
non-RCU softirq handlers are still enabled when checking to stop the
scheduler-tick interrupt.  This message is not as enlightening as one
might hope, so this commit changes it to "NOHZ tick-stop error: Non-RCU
local softirq work is pending, handler #HH".

Reported-by: Andy Lutomirski <luto@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 5022b8ac

kernel/time/tick-sched.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -927,7 +927,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)

		if (ratelimit < 10 &&
		(local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
		pr_warn("NOHZ: local_softirq_pending %02x\n",
		pr_warn("NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #%02x!!!\n",
		(unsigned int) local_softirq_pending());
		ratelimit++;
		}

Admin message