Commit bca237a5 authored by Kees Cook's avatar Kees Cook
Browse files

block/laptop_mode: Convert timers to use timer_setup() 



In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Jeff Layton <jlayton@redhat.com>
Cc: linux-block@vger.kernel.org
Cc: linux-mm@kvack.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent 1e9aa74e

block/blk-core.c

+5 −5
Original line number Diff line number Diff line
@@ -863,9 +863,9 @@ static void blk_queue_usage_counter_release(struct percpu_ref *ref) 
	wake_up_all(&q->mq_freeze_wq);

}



static void blk_rq_timed_out_timer(unsigned long data)

static void blk_rq_timed_out_timer(struct timer_list *t)

{

	struct request_queue *q = (struct request_queue *)data;

	struct request_queue *q = from_timer(q, t, timeout);



	kblockd_schedule_work(&q->timeout_work);

}
@@ -901,9 +901,9 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) 
	q->backing_dev_info->name = "block";

	q->node = node_id;



	setup_timer(&q->backing_dev_info->laptop_mode_wb_timer,

		    laptop_mode_timer_fn, (unsigned long) q);

	setup_timer(&q->timeout, blk_rq_timed_out_timer, (unsigned long) q);

	timer_setup(&q->backing_dev_info->laptop_mode_wb_timer,

		    laptop_mode_timer_fn, 0);

	timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);

	INIT_WORK(&q->timeout_work, NULL);

	INIT_LIST_HEAD(&q->queue_head);

	INIT_LIST_HEAD(&q->timeout_list);

include/linux/writeback.h

+1 −1
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ static inline void cgroup_writeback_umount(void) 
void laptop_io_completion(struct backing_dev_info *info);

void laptop_sync_completion(void);

void laptop_mode_sync(struct work_struct *work);

void laptop_mode_timer_fn(unsigned long data);

void laptop_mode_timer_fn(struct timer_list *t);

#else

static inline void laptop_sync_completion(void) { }

#endif

mm/page-writeback.c

+4 −3
Original line number Diff line number Diff line
@@ -1993,11 +1993,12 @@ int dirty_writeback_centisecs_handler(struct ctl_table *table, int write, 
}



#ifdef CONFIG_BLOCK

void laptop_mode_timer_fn(unsigned long data)

void laptop_mode_timer_fn(struct timer_list *t)

{

	struct request_queue *q = (struct request_queue *)data;

	struct backing_dev_info *backing_dev_info =

		from_timer(backing_dev_info, t, laptop_mode_wb_timer);



	wakeup_flusher_threads_bdi(q->backing_dev_info, WB_REASON_LAPTOP_TIMER);

	wakeup_flusher_threads_bdi(backing_dev_info, WB_REASON_LAPTOP_TIMER);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE