ASIX: Use only 11 bits of header for data size (bca0beb9) · Commits · 戴 / test

The AX88772B uses only 11 bits of the header for the actual size. The other bits are used for something else. This causes dmesg full of messages: asix_rx_fixup() Bad Header Length This patch trims the check to only 11 bits. I believe on older chips, the remaining 5 top bits are unused. Signed-off-by:

Marek Vasut <marek.vasut@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/usb/asix.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -314,11 +314,11 @@ static int asix_rx_fixup(struct usbnet dev, struct sk_buff skb)
	skb_pull(skb, 4);		skb_pull(skb, 4);

	while (skb->len > 0) {		while (skb->len > 0) {
	if ((header & 0xffff) != ((~header >> 16) & 0xffff))		if ((header & 0x07ff) != ((~header >> 16) & 0x07ff))
	netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n");		netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n");

	/* get the packet length */		/* get the packet length */
	size = (u16) (header & 0x0000ffff);		size = (u16) (header & 0x000007ff);

	if ((skb->len) - ((size + 1) & 0xfffe) == 0) {		if ((skb->len) - ((size + 1) & 0xfffe) == 0) {
	u8 alignment = (unsigned long)skb->data & 0x3;		u8 alignment = (unsigned long)skb->data & 0x3;

Admin message