Commit bc9af23d authored Feb 15, 2016 by Jon Hunter Committed by Thierry Reding Apr 05, 2016

soc/tegra: pmc: Ensure GPU partition can be toggled on/off by PMC

For Tegra124 and Tegra210, the GPU partition cannot be toggled on and
off via the APBDEV_PMC_PWRGATE_TOGGLE_0 register. For these devices, the
partition is simply powered up and down via an external regulator.
For these devices, there is a separate register for controlling the
signal clamping of the partition and this is described in the PMC SoC
data by the "has_gpu_clamp" variable. Use this variable to determine if
the GPU partition can be controlled via the APBDEV_PMC_PWRGATE_TOGGLE_0
register and ensure that no one can incorrectly try to toggle the GPU
partition via the APBDEV_PMC_PWRGATE_TOGGLE_0 register.

Furthermore, we cannot use the APBDEV_PMC_PWRGATE_STATUS_0 register to
determine if the GPU partition is powered for Tegra124 and Tegra210.
However, if the GPU partition is powered, then the signal clamp for the
GPU partition should be removed and so use bit 0 of the
APBDEV_PMC_GPU_RG_CNTRL_0 register to determine if the clamp has been
removed (bit[0] = 0) and the GPU partition is powered.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent c3ea2972

drivers/soc/tegra/pmc.c

+7 −1

Original line number	Original line	Diff line number	Diff line
	@@ -176,6 +176,9 @@ static void tegra_pmc_writel(u32 value, unsigned long offset)

	static inline bool tegra_powergate_state(int id)		static inline bool tegra_powergate_state(int id)
	{		{
			if (id == TEGRA_POWERGATE_3D && pmc->soc->has_gpu_clamps)
			return (tegra_pmc_readl(GPU_RG_CNTRL) & 0x1) == 0;
			else
	return (tegra_pmc_readl(PWRGATE_STATUS) & BIT(id)) != 0;		return (tegra_pmc_readl(PWRGATE_STATUS) & BIT(id)) != 0;
	}		}

	@@ -191,6 +194,9 @@ static inline bool tegra_powergate_is_valid(int id)
	*/		*/
	static int tegra_powergate_set(unsigned int id, bool new_state)		static int tegra_powergate_set(unsigned int id, bool new_state)
	{		{
			if (id == TEGRA_POWERGATE_3D && pmc->soc->has_gpu_clamps)
			return -EINVAL;

	mutex_lock(&pmc->powergates_lock);		mutex_lock(&pmc->powergates_lock);

	if (tegra_powergate_state(id) == new_state) {		if (tegra_powergate_state(id) == new_state) {

Admin message