Commit bc92657a authored by Stephen Warren's avatar Stephen Warren Committed by Mark Brown
Browse files

ASoC: make snd_soc_dai_link more symmetrical 



Prior to this patch, the CPU side of a DAI link was specified using a
single name. Often, this was the result of calling dev_name() on the
device providing the DAI, but in the case of a CPU DAI driver that
provided multiple DAIs, it needed to mix together both the device name
and some device-relative name, in order to form a single globally unique
name.

However, the CODEC side of the DAI link was specified using separate
fields for device (name or OF node) and device-relative DAI name.

This patch allows the CPU side of a DAI link to be specified in the same
way as the CODEC side, separating concepts of device and device-relative
DAI name.

I believe this will be important in multi-codec and/or dynamic PCM
scenarios, where a single CPU driver provides multiple DAIs, while also
booting using device tree, with accompanying desire not to hard-code the
CPU side device's name into the original .cpu_dai_name field.

Ideally, both the CPU DAI and CODEC DAI loops in soc_bind_dai_link()
would now be identical. However, two things prevent that at present:

1) The need to save rtd->codec for the CODEC side, which means we have
to search for the CODEC explicitly, and not just the CODEC side DAI.

2) Since we know the CODEC side DAI is part of a codec, and not just
a standalone DAI, it's slightly more efficient to convert .codec_name/
.codec_of_node into a codec first, and then compare each DAI's .codec
field, since this avoids strcmp() on each DAI's CODEC's name within
the loop.

However, the two loops are essentially semantically equivalent.

Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 210cb67c

include/sound/soc.h

+28 −5
Original line number Diff line number Diff line
@@ -785,13 +785,36 @@ struct snd_soc_dai_link { 
	/* config - must be set by machine driver */

	const char *name;			/* Codec name */

	const char *stream_name;		/* Stream name */

	const char *codec_name;		/* for multi-codec */

	const struct device_node *codec_of_node;

	const char *platform_name;	/* for multi-platform */

	const struct device_node *platform_of_node;

	/*

	 * You MAY specify the link's CPU-side device, either by device name,

	 * or by DT/OF node, but not both. If this information is omitted,

	 * the CPU-side DAI is matched using .cpu_dai_name only, which hence

	 * must be globally unique. These fields are currently typically used

	 * only for codec to codec links, or systems using device tree.

	 */

	const char *cpu_name;

	const struct device_node *cpu_of_node;

	/*

	 * You MAY specify the DAI name of the CPU DAI. If this information is

	 * omitted, the CPU-side DAI is matched using .cpu_name/.cpu_of_node

	 * only, which only works well when that device exposes a single DAI.

	 */

	const char *cpu_dai_name;

	const struct device_node *cpu_dai_of_node;

	/*

	 * You MUST specify the link's codec, either by device name, or by

	 * DT/OF node, but not both.

	 */

	const char *codec_name;

	const struct device_node *codec_of_node;

	/* You MUST specify the DAI name within the codec */

	const char *codec_dai_name;

	/*

	 * You MAY specify the link's platform/PCM/DMA driver, either by

	 * device name, or by DT/OF node, but not both. Some forms of link

	 * do not need a platform.

	 */

	const char *platform_name;

	const struct device_node *platform_of_node;

	int be_id;	/* optional ID for machine driver BE identification */



	const struct snd_soc_pcm_stream *params;

sound/soc/mxs/mxs-sgtl5000.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int __devinit mxs_sgtl5000_probe_dt(struct platform_device *pdev) 
		mxs_sgtl5000_dai[i].codec_name = NULL;

		mxs_sgtl5000_dai[i].codec_of_node = codec_np;

		mxs_sgtl5000_dai[i].cpu_dai_name = NULL;

		mxs_sgtl5000_dai[i].cpu_dai_of_node = saif_np[i];

		mxs_sgtl5000_dai[i].cpu_of_node = saif_np[i];

		mxs_sgtl5000_dai[i].platform_name = NULL;

		mxs_sgtl5000_dai[i].platform_of_node = saif_np[i];

	}

sound/soc/soc-core.c

+31 −11
Original line number Diff line number Diff line
@@ -812,13 +812,15 @@ static int soc_bind_dai_link(struct snd_soc_card *card, int num) 


	/* Find CPU DAI from registered DAIs*/

	list_for_each_entry(cpu_dai, &dai_list, list) {

		if (dai_link->cpu_dai_of_node) {

			if (cpu_dai->dev->of_node != dai_link->cpu_dai_of_node)

		if (dai_link->cpu_of_node &&

		    (cpu_dai->dev->of_node != dai_link->cpu_of_node))

			continue;

		} else {

			if (strcmp(cpu_dai->name, dai_link->cpu_dai_name))

		if (dai_link->cpu_name &&

		    strcmp(dev_name(cpu_dai->dev), dai_link->cpu_name))

			continue;

		if (dai_link->cpu_dai_name &&

		    strcmp(cpu_dai->name, dai_link->cpu_dai_name))

			continue;

		}



		rtd->cpu_dai = cpu_dai;

	}
@@ -3346,6 +3348,12 @@ int snd_soc_register_card(struct snd_soc_card *card) 
				link->name);

			return -EINVAL;

		}

		/* Codec DAI name must be specified */

		if (!link->codec_dai_name) {

			dev_err(card->dev, "codec_dai_name not set for %s\n",

				link->name);

			return -EINVAL;

		}



		/*

		 * Platform may be specified by either name or OF node, but
@@ -3358,12 +3366,24 @@ int snd_soc_register_card(struct snd_soc_card *card) 
		}



		/*

		 * CPU DAI must be specified by 1 of name or OF node,

		 * not both or neither.

		 * CPU device may be specified by either name or OF node, but

		 * can be left unspecified, and will be matched based on DAI

		 * name alone..

		 */

		if (link->cpu_name && link->cpu_of_node) {

			dev_err(card->dev,

				"Neither/both cpu name/of_node are set for %s\n",

				link->name);

			return -EINVAL;

		}

		/*

		 * At least one of CPU DAI name or CPU device name/node must be

		 * specified

		 */

		if (!!link->cpu_dai_name == !!link->cpu_dai_of_node) {

		if (!link->cpu_dai_name &&

		    !(link->cpu_name || link->cpu_of_node)) {

			dev_err(card->dev,

				"Neither/both cpu_dai name/of_node are set for %s\n",

				"Neither cpu_dai_name nor cpu_name/of_node are set for %s\n",

				link->name);

			return -EINVAL;

		}

sound/soc/tegra/tegra_alc5632.c

+3 −3
Original line number Diff line number Diff line
@@ -197,16 +197,16 @@ static __devinit int tegra_alc5632_probe(struct platform_device *pdev) 
		goto err;

	}



	tegra_alc5632_dai.cpu_dai_of_node = of_parse_phandle(

	tegra_alc5632_dai.cpu_of_node = of_parse_phandle(

			pdev->dev.of_node, "nvidia,i2s-controller", 0);

	if (!tegra_alc5632_dai.cpu_dai_of_node) {

	if (!tegra_alc5632_dai.cpu_of_node) {

		dev_err(&pdev->dev,

		"Property 'nvidia,i2s-controller' missing or invalid\n");

		ret = -EINVAL;

		goto err;

	}



	tegra_alc5632_dai.platform_of_node = tegra_alc5632_dai.cpu_dai_of_node;

	tegra_alc5632_dai.platform_of_node = tegra_alc5632_dai.cpu_of_node;



	ret = tegra_asoc_utils_init(&alc5632->util_data, &pdev->dev);

	if (ret)

sound/soc/tegra/tegra_wm8753.c

+3 −3
Original line number Diff line number Diff line
@@ -157,9 +157,9 @@ static __devinit int tegra_wm8753_driver_probe(struct platform_device *pdev) 
		goto err;

	}



	tegra_wm8753_dai.cpu_dai_of_node = of_parse_phandle(

	tegra_wm8753_dai.cpu_of_node = of_parse_phandle(

			pdev->dev.of_node, "nvidia,i2s-controller", 0);

	if (!tegra_wm8753_dai.cpu_dai_of_node) {

	if (!tegra_wm8753_dai.cpu_of_node) {

		dev_err(&pdev->dev,

			"Property 'nvidia,i2s-controller' missing or invalid\n");

		ret = -EINVAL;
@@ -167,7 +167,7 @@ static __devinit int tegra_wm8753_driver_probe(struct platform_device *pdev) 
	}



	tegra_wm8753_dai.platform_of_node =

				tegra_wm8753_dai.cpu_dai_of_node;

				tegra_wm8753_dai.cpu_of_node;



	ret = tegra_asoc_utils_init(&machine->util_data, &pdev->dev);

	if (ret)

CRA Git | Maintained and supported by SUSTech CRA and CCSE