Commit bc923818 authored Nov 08, 2020 by Zhang Qilong Committed by Andreas Gruenbacher Nov 12, 2020

gfs2: fix possible reference leak in gfs2_check_blk_type



In the fail path of gfs2_check_blk_type, forgetting to call
gfs2_glock_dq_uninit will result in rgd_gh reference leak.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent f8394f23

fs/gfs2/rgrp.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -2529,13 +2529,13 @@ int gfs2_check_blk_type(struct gfs2_sbd *sdp, u64 no_addr, unsigned int type)

		rbm.rgd = rgd;
		error = gfs2_rbm_from_block(&rbm, no_addr);
		if (WARN_ON_ONCE(error))
		goto fail;

		if (!WARN_ON_ONCE(error)) {
		if (gfs2_testbit(&rbm, false) != type)
		error = -ESTALE;
		}

		gfs2_glock_dq_uninit(&rgd_gh);

		fail:
		return error;
		}

Admin message