Commit bc508161 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: drop FIFO resizing logic 



That FIFO resizing logic was added to support OMAP5
ES1.0 which had a bogus default FIFO size. I can't
remember the exact size of default FIFO, but it was
less than one bulk superspeed packet (<1024) which
would prevent USB3 from ever working on OMAP5 ES1.0.

However, OMAP5 ES1.0 support has been dropped by
commit aa2f4b16 ("ARM: OMAP5: id: Remove ES1.0
support") which renders FIFO resizing unnecessary.

Tested-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent bf162006

Documentation/devicetree/bindings/usb/dwc3.txt

+2 −2
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ Optional properties: 
   the second element is expected to be a handle to the USB3/SS PHY

 - phys: from the *Generic PHY* bindings

 - phy-names: from the *Generic PHY* bindings

 - tx-fifo-resize: determines if the FIFO *has* to be reallocated.

 - snps,usb3_lpm_capable: determines if platform is USB3 LPM capable

 - snps,disable_scramble_quirk: true when SW should disable data scrambling.

	Only really useful for FPGA builds.
@@ -47,6 +46,8 @@ Optional properties: 
	register for post-silicon frame length adjustment when the

	fladj_30mhz_sdbnd signal is invalid or incorrect.



 - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.



This is usually a subnode to DWC3 glue to which it is connected.



dwc3@4a030000 {
@@ -54,5 +55,4 @@ dwc3@4a030000 { 
	reg = <0x4a030000 0xcfff>;

	interrupts = <0 92 4>

	usb-phy = <&usb2_phy>, <&usb3,phy>;

	tx-fifo-resize;

};

Documentation/devicetree/bindings/usb/qcom,dwc3.txt

+0 −1
Original line number Diff line number Diff line
@@ -59,7 +59,6 @@ Example device nodes: 
				interrupts = <0 205 0x4>;

				phys = <&hs_phy>, <&ss_phy>;

				phy-names = "usb2-phy", "usb3-phy";

				tx-fifo-resize;

				dr_mode = "host";

			};

		};

drivers/usb/dwc3/core.c

+0 −4
Original line number Diff line number Diff line
@@ -882,9 +882,6 @@ static int dwc3_probe(struct platform_device *pdev) 
	dwc->usb3_lpm_capable = device_property_read_bool(dev,

				"snps,usb3_lpm_capable");



	dwc->needs_fifo_resize = device_property_read_bool(dev,

				"tx-fifo-resize");



	dwc->disable_scramble_quirk = device_property_read_bool(dev,

				"snps,disable_scramble_quirk");

	dwc->u2exit_lfps_quirk = device_property_read_bool(dev,
@@ -926,7 +923,6 @@ static int dwc3_probe(struct platform_device *pdev) 
		if (pdata->hird_threshold)

			hird_threshold = pdata->hird_threshold;



		dwc->needs_fifo_resize = pdata->tx_fifo_resize;

		dwc->usb3_lpm_capable = pdata->usb3_lpm_capable;

		dwc->dr_mode = pdata->dr_mode;

drivers/usb/dwc3/core.h

+0 −5
Original line number Diff line number Diff line
@@ -709,9 +709,7 @@ struct dwc3_scratchpad_array { 
 * 	0	- utmi_sleep_n

 * 	1	- utmi_l1_suspend_n

 * @is_fpga: true when we are using the FPGA board

 * @needs_fifo_resize: not all users might want fifo resizing, flag it

 * @pullups_connected: true when Run/Stop bit is set

 * @resize_fifos: tells us it's ok to reconfigure our TxFIFO sizes.

 * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround

 * @start_config_issued: true when StartConfig command has been issued

 * @three_stage_setup: set if we perform a three phase setup
@@ -855,9 +853,7 @@ struct dwc3 { 
	unsigned		has_lpm_erratum:1;

	unsigned		is_utmi_l1_suspend:1;

	unsigned		is_fpga:1;

	unsigned		needs_fifo_resize:1;

	unsigned		pullups_connected:1;

	unsigned		resize_fifos:1;

	unsigned		setup_packet_pending:1;

	unsigned		three_stage_setup:1;

	unsigned		usb3_lpm_capable:1;
@@ -1025,7 +1021,6 @@ struct dwc3_gadget_ep_cmd_params { 


/* prototypes */

void dwc3_set_mode(struct dwc3 *dwc, u32 mode);

int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc);



/* check whether we are on the DWC_usb31 core */

static inline bool dwc3_is_usb31(struct dwc3 *dwc)

drivers/usb/dwc3/ep0.c

+0 −9
Original line number Diff line number Diff line
@@ -586,9 +586,6 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) 
			reg = dwc3_readl(dwc->regs, DWC3_DCTL);

			reg |= (DWC3_DCTL_ACCEPTU1ENA | DWC3_DCTL_ACCEPTU2ENA);

			dwc3_writel(dwc->regs, DWC3_DCTL, reg);



			dwc->resize_fifos = true;

			dwc3_trace(trace_dwc3_ep0, "resize FIFOs flag SET");

		}

		break;
@@ -1027,12 +1024,6 @@ static int dwc3_ep0_start_control_status(struct dwc3_ep *dep) 


static void __dwc3_ep0_do_control_status(struct dwc3 *dwc, struct dwc3_ep *dep)

{

	if (dwc->resize_fifos) {

		dwc3_trace(trace_dwc3_ep0, "Resizing FIFOs");

		dwc3_gadget_resize_tx_fifos(dwc);

		dwc->resize_fifos = 0;

	}



	WARN_ON(dwc3_ep0_start_control_status(dep));

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE