Commit bc4f6e06 authored by Dan Carpenter's avatar Dan Carpenter Committed by Sagi Grimberg
Browse files

nvme: fix an error code in nvme_init_subsystem() 



"ret" should be a negative error code here, but it's either success or
possibly uninitialized.

Fixes: 32fd90c4 ("nvme: change locking for the per-subsystem controller list")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
parent 7cbb5c6f

drivers/nvme/host/core.c

+3 −2
Original line number Diff line number Diff line
@@ -2543,8 +2543,9 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) 
		list_add_tail(&subsys->entry, &nvme_subsystems);

	}



	if (sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj,

			dev_name(ctrl->device))) {

	ret = sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj,

				dev_name(ctrl->device));

	if (ret) {

		dev_err(ctrl->device,

			"failed to create sysfs link from subsystem.\n");

		goto out_put_subsystem;

CRA Git | Maintained and supported by SUSTech CRA and CCSE