Commit bc4eec76 authored Nov 07, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Nov 27, 2017

staging: comedi: usbdux: remove redundant initialization of val



The early initialization of val is redundant as the value is never
read and is updated inside a for-loop. Remove the initialization
and move the declaration and initialization to the for-loop scope.
Cleans up clang warning:

drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
to 'val' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d69b9c38

drivers/staging/comedi/drivers/usbdux.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
		{
		struct usbdux_private *devpriv = dev->private;
		unsigned int chan = CR_CHAN(insn->chanspec);
		unsigned int val = s->readback[chan];
		__le16 p = (__le16 )&devpriv->dux_commands[2];
		int ret = -EBUSY;
		int i;
		@@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
		devpriv->dux_commands[4] = chan << 6;

		for (i = 0; i < insn->n; i++) {
		val = data[i];
		unsigned int val = data[i];

		/* one 16 bit value */
		*p = cpu_to_le16(val);

Admin message