Commit bc2aba90 authored Oct 27, 2017 by Dan Carpenter Committed by Tomi Valkeinen Nov 30, 2017

omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()



"ret" needs to be signed for the error handling to work.

Fixes: 8d7f934d ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent bf25dac3

drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device pdev, struct hdmi_core_data core,
		{
		const u32 caps = CEC_CAP_TRANSMIT \| CEC_CAP_LOG_ADDRS \|
		CEC_CAP_PASSTHROUGH \| CEC_CAP_RC;
		unsigned int ret;
		int ret;

		core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
		"omap4", caps, CEC_MAX_LOG_ADDRS);

Admin message