Commit bc20589b authored Oct 15, 2008 by Andrew Morton Committed by Linus Torvalds Oct 16, 2008

applicom.c: fix apparently-broken code in do_ac_read()

The code scriblles over a local pointer whereas it appears to be trying
to write to the memory at which that pointer points.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11397



Nobody we know can test this change.

Reported-by: Zvonimir Rakamaric <zrakamar@cs.ubc.ca>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d05abab9

drivers/char/applicom.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -478,7 +478,7 @@ static int do_ac_read(int IndexCard, char __user *buf,
		struct st_ram_io st_loc, struct mailbox mailbox)
		{
		void __iomem *from = apbs[IndexCard].RamIO + RAM_TO_PC;
		unsigned char to = (unsigned char )&mailbox;
		unsigned char to = (unsigned char )mailbox;
		#ifdef DEBUG
		int c;
		#endif

Admin message