Commit bc18dd33 authored Aug 06, 2014 by Ken Helias Committed by Linus Torvalds Aug 06, 2014

list: make hlist_add_after() argument names match hlist_add_after_rcu()



The argument names for hlist_add_after() are poorly chosen because they
look the same as the ones for hlist_add_before() but have to be used
differently.

hlist_add_after_rcu() has made a better choice.

Signed-off-by: Ken Helias <kenhelias@firemail.de>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d25d9fec

include/linux/list.h

+7 −7

Original line number	Diff line number	Diff line
		@@ -654,15 +654,15 @@ static inline void hlist_add_before(struct hlist_node *n,
		*(n->pprev) = n;
		}

		static inline void hlist_add_after(struct hlist_node *n,
		struct hlist_node *next)
		static inline void hlist_add_after(struct hlist_node *prev,
		struct hlist_node *n)
		{
		next->next = n->next;
		n->next = next;
		next->pprev = &n->next;
		n->next = prev->next;
		prev->next = n;
		n->pprev = &prev->next;

		if(next->next)
		next->next->pprev = &next->next;
		if (n->next)
		n->next->pprev = &n->next;
		}

		/* after that we'll appear to be on some hlist and hlist_del will work */

Admin message