Commit bbfa57c0 authored Feb 21, 2013 by Sebastian Riemer Committed by NeilBrown Feb 21, 2013

md: protect against crash upon fsync on ro array



If an fsync occurs on a read-only array, we need to send a
completion for the IO and may not increment the active IO count.
Otherwise, we hit a bug trace and can't stop the MD array anymore.

By advice of Christoph Hellwig we return success upon a flush
request but we return -EROFS for other writes.
We detect flush requests by checking if the bio has zero sectors.

This patch is suitable to any -stable kernel to which it applies.

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 19f949f5

drivers/md/md.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -307,6 +307,10 @@ static void md_make_request(struct request_queue q, struct bio bio)
		bio_io_error(bio);
		return;
		}
		if (mddev->ro == 1 && unlikely(rw == WRITE)) {
		bio_endio(bio, bio_sectors(bio) == 0 ? 0 : -EROFS);
		return;
		}
		smp_rmb(); /* Ensure implications of 'active' are visible */
		rcu_read_lock();
		if (mddev->suspended) {

Admin message