Commit bbf4ac9c authored Apr 20, 2016 by Heiner Kallweit Committed by Jiri Kosina Apr 25, 2016

HID: thingm: remove not needed error message



LED core takes care of handling failed calls to thingm_let_set.
- print error message in set_brightness_delayed or
- pass error to caller in led_set_brightness_sync
Also the error message here doesn't provide any hint what actually
went wrong. Therefore remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@rehat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent a4362fd6

drivers/hid/hid-thingm.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev,
		enum led_brightness brightness)
		{
		struct thingm_led *led = container_of(ldev, struct thingm_led, ldev);
		int ret;

		ret = thingm_write_color(led->rgb);
		if (ret)
		hid_err(led->rgb->tdev->hdev, "failed to write color\n");

		return ret;
		return thingm_write_color(led->rgb);
		}

		static int thingm_init_led(struct thingm_led led, const char color_name,

Admin message